Nev

Results 393 comments of Nev

JSON.stringify() is not the specific driver for this spec issue. The issue is that the definitions are not consistent which means an Attribute is not always the same Attribute. We...

@tigrannajaryan That is where the inconsistencies are as the Spec also [states here](https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/common#attribute-collections) > "[Resources](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md), Metrics [data points](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#metric-points), [Spans](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#set-attributes), Span [Events](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#add-events), Span [Links](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#specifying-links) and [Log Records](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md) may contain a collection...

> > Clarifies the Attribute support as defined by Proto AnyValue and clarifies Attribute Collections. > > Clarifies and identifies `how nested attributes support (as defined by Proto and some...

> Please give this PR a more descriptive title. I think the "inconsistency" issue has been explained. It seems to me this is not solving an inconsistency but proposing a...

> In practice, you are proposing a new feature. This is not supported today. That is because none of the SDK's (that I'm aware of) are currently SPEC compliant for...

> What should be "clarified" then, is that Log Attributes are not the general attribute type. That is what I'm attempting to do here without forcing the introduction of yet...

This last (forced) push is just to bring the PR up to date and mark as not stale. Forced push was required as git refused to do a normal push.

FYI from spec meeting this morning re an Events API support on Logs https://github.com/open-telemetry/opentelemetry-specification/pull/2676

Agree, from (vague) memory this is why I had it before. So > reviving setLogLevel Yes > change setLogger so that second argument, unless provided, doesn't change the log level...