Maarten Segers

Hi @christianwiedemann, could you clarify what the problem is here? Before looping the bundles, the list is initialized as an empty array: $permissions = [];

Cf. https://github.com/Gizra/og/pull/748

Adding screenshots for documentation: ## Configure og_access on group/group content bundle settings: ### Node form for group ### Node form for group content

We've been testing this patch for some time and noticed that the group's cache tags don't appear on group content so Varnish won't purge group content pages when the group...

Since we're adding a node_access implementation here, we should probably add a call to node_access_rebuild() in hook_install().

@heddn, this looks very good. Why didn't you create a view like the one used to manage members (OgAdminMembersController); what's the advantage of using a custom table versus a view...

@pfrenssen, we should probably add GroupPermission (view all permissions) & GroupContentOperationPermission (view any $bundle_id content revisions)?

4 tests seem to fail and there are quite some codesniffer issues. @pfrenssen @amitaibu perhaps we can configure [code climate](https://codeclimate.com/oss/) which is free for open source? It makes reviewing/fixing coding...

> > Note: I'll try to do a full pass on @MPParsley's review comments soon. > > Commit [mradcliffe@ff85cda](https://github.com/mradcliffe/og/commit/ff85cda24b02c12c2d9fc3eb55644fbf344291cb) deals with all @MPParsley's review comments. Thanks, perhaps you can also...

Tests are failing: ``` 1) Drupal\Tests\og\Kernel\Migrate\OgEntityMembershipD7MigrateTest::testOgMembership Group content migrated Failed asserting that actual size 2 matches expected size 4. /home/travis/build/Gizra/og/tests/src/Kernel/Migrate/OgEntityMembershipD7MigrateTest.php:91 ```