isobmff icon indicating copy to clipboard operation
isobmff copied to clipboard

Bugfix/memory leak

Open ohjiwoo123 opened this issue 2 years ago • 5 comments

First, Solved Memory Leak in traf (MP4TrackFragmentAtom)
Second, Solved Memory Leak in trex (MP4TrackExtendsAtom)

If user makes Fragment Mp4, There are some memory leak.
There is no memory free for MP4TrackFragmentAtom.
There is no memory free for MP4TrackExtendsAtom.

After add Code and completing the test, There is no memory leak.

ohjiwoo123 avatar Dec 12 '23 16:12 ohjiwoo123

Thanks, there seem to be a problem with the compilation on linux and some basic clang-format issues.

podborski avatar Dec 12 '23 19:12 podborski

Complete the Change Formatting with clang-format.
Could you try again?
Thank you.

ohjiwoo123 avatar Dec 13 '23 06:12 ohjiwoo123

Do I must use formatting clang-format vesion 13 ? ( as written in isobmff/.github/workflows/clang-format.yml ) I am formatting file with clang-format version 18.0.0

ohjiwoo123 avatar Dec 14 '23 06:12 ohjiwoo123

I think that you need to change the clang-format.yml file (version up)
If I use jidicula/[email protected] version, The error raised like below.

Installing clang-format-13
E: Unable to locate package clang-format-13
Not a directory in the workspace, fallback to all files.
/entrypoint.sh: line 23: /usr/bin/clang-format-13: No such file or directory

https://github.com/MPEGGroup/isobmff/blob/master/.github/workflows/clang-format.yml

jidicula/[email protected] -> jidicula/[email protected]
or
jidicula/[email protected]
Thank you

ohjiwoo123 avatar Dec 15 '23 01:12 ohjiwoo123

Yep, I remember we fixed some of those issues in the sgpd_versions branch. It now has a lot of useful changes in it. I suggest we merge this one to that branch as well.

podborski avatar Jan 03 '24 01:01 podborski