modflow6 icon indicating copy to clipboard operation
modflow6 copied to clipboard

Published 20 hours ago • verified publisher icon MODFLOW-USGS

chore(gwf-sfr.f90): stylistic consistency

Open emorway-usgs opened this issue 10 months ago • 4 comments

  • minor stuff for consistent presentation
  • fprettify

emorway-usgs avatar Apr 23 '24 17:04 emorway-usgs

@jdhughes-usgs, is this going to conflict with your SFR refactoring?

langevin-usgs avatar Apr 24 '24 12:04 langevin-usgs

@jdhughes-usgs, is this going to conflict with your SFR refactoring?

There will definitely be conflicts. I can wait until #1761 goes in and get this PR up-to-date.

Before initiating this PR, I checked to see if there were any open PRs with SFR modifications. Not seeing any, I submitted this one, but it looks like it was only shortly before #1761.

emorway-usgs avatar Apr 24 '24 13:04 emorway-usgs

@jdhughes-usgs, is this going to conflict with your SFR refactoring?

There will definitely be conflicts. I can wait until #1761 goes in and get this PR up-to-date.

Before initiating this PR, I checked to see if there were any open PRs with SFR modifications. Not seeing any, I submitted this one, but it looks like it was only shortly before #1761.

@langevin-usgs @emorway-usgs Yes this will conflict with my refactoring.

jdhughes-usgs avatar Apr 24 '24 14:04 jdhughes-usgs

@langevin-usgs @emorway-usgs @wpbonelli I also don't think we should be capitalizing the first letter of a comment if it is not a sentence. We need to get finalize the Fortran style for mf6 and get a python tool up and running.

jdhughes-usgs avatar Apr 24 '24 14:04 jdhughes-usgs

I'm going to close this for now. We might need to formalize commenting style before making these changes

langevin-usgs avatar May 13 '24 11:05 langevin-usgs