MM2-0
Migrate osm opening hours parsing to external library
closes #860.
I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of :core:ktx also use JUnit I'd use that.
There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the opening_hours spec actually is. ("sunrise to sunset" is a thing!)
I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of :core:ktx also use JUnit I'd use that.
Afaik Android officially still only supports JUnit 4 as a testing library, so I'm fine with that.
There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the opening_hours spec actually is. ("sunrise to sunset" is a thing!)
Oh no! :D
I'd like to publish a release today, so this will probably have to wait for the next version if that's alright?
I'd like to publish a release today, so this will probably have to wait for the next version if that's alright?
Sure, no problem. I'm not in a hurry :)
Hey there, it's been a while but finally I found some time to have a look at this again. I made up my mind and now consider support for the whole opening_hours_spec to be out of scope. Still, this PR adds support for more types of opening_hours than currently available. I've added tests for parsing, feel free to have a look and tell me whether or not you think that is enough coverage...
Anyway, I consider this to be "ready for review".