[Request] [BUG?] Apps with visibility "Search results" should not show up in Favorites box

[thyttan]

Hi,

Problem

Not sure if this is a bug or intended behavior. But if I switch the visibility of an app from "App grid and search results" to "Search results" the app will still show up in my "Favorites" box. The "Never" option hides the app from the "Favorites" box as well as expected.

Expectation

Apps marked with "Show in" "Search results" should only be visible once I start typing in the search box and not anywhere else.

Solution

Make apps hide from the "Favorites" box if its visibility is set to "Search results" leaving them to only show if they match what I type in the search field.

Alternative solution

Add a new option for this behavior that's a middle ground of the current "Search results" and "Never" options (this doesn't make as much sense to me though).

Closing remarks

I see at https://github.com/MM2-0/Kvaesitso/issues/942#issuecomment-2222601638 the current behavior may be intended? in which case I hope you may reconsider! :)

Thanks again for kvaesitso and your work!