mlh-localhost-github icon indicating copy to clipboard operation
mlh-localhost-github copied to clipboard

updates

Open maralihart opened this issue 4 years ago • 3 comments

maralihart avatar Jul 09 '21 18:07 maralihart

This is looking great!

A couple points of feedback & requests for updates on the Leaflet side of the world:

  • [x] Leaflet.markercluster's zoomToBoundsOnClick isn't working, can you debug and get it to work.
  • [ ] I'd like it so each icon gets a popup when you click it saying the location and the GitHub user who added it. Can you please do so? You'll need to edit src/locations.js to make that work.
  • [ ] Because Leaflet doesn't use Google Maps tiles, we need a new geocoding engine, can you find one and let me know what we need to get it working?

nquinlan avatar Aug 02 '21 19:08 nquinlan

Regarding automerging, I think a better implementation would be to implement a test framework in this repository. The test framework should test the merge, see that only one line was changed and then mark that test passing.

It should then check the GitHub PR to see if there's a react on it by someone other than the author. If there is that test should pass.

If both tests pass it should then have a separate action (which should already exist) that automeges when there are passed tests.

nquinlan avatar Aug 02 '21 19:08 nquinlan

  • [ ] Because Leaflet doesn't use Google Maps tiles, we need a new geocoding engine, can you find one and let me know what we need to get it working?

Potential API: https://docs.mapbox.com/api/search/geocoding/#endpoints -- may cost money? Would have to contact Sales team, but perhaps they'd be willing to work something out?

maralihart avatar Aug 09 '21 21:08 maralihart