mlb-led-scoreboard icon indicating copy to clipboard operation
mlb-led-scoreboard copied to clipboard

Seeing shortened team names with RHE off

Open twfarley opened this issue 2 years ago • 3 comments

   "runs": {
      "runs_hits_errors": {
        "show": false,
        "compress_digits": false,
        "spacing": 3
      },  

I'm still seeing shortened team names with this disabled.

twfarley avatar May 23 '22 05:05 twfarley

Do you have "full_team_names": false, in config.json?

WardBrian avatar Aug 04 '22 02:08 WardBrian

No, it's set to true.

twfarley avatar Aug 04 '22 06:08 twfarley

and in coords file

    "runs": {
      "runs_hits_errors": {
        "show": false,
        "compress_digits": false,
        "spacing": 3
      }, 

twfarley avatar Aug 04 '22 06:08 twfarley

This can be repro'd by always setting runs to > 9 in data/scoreboard/team.py while a game is ongoing

class Team:
    def __init__(self, abbrev, runs, name, hits, errors):
        self.abbrev = abbrev
        self.runs = 10 
        self.name = name
        self.hits = hits
        self.errors = errors

ty-porter avatar Feb 25 '23 21:02 ty-porter

I didn't have "short_team_names_for_runs_hits": true, I my config file...

No longer reproducing after adding it. /facepalm

twfarley avatar Feb 26 '23 23:02 twfarley

I think we can close this in favor of #422 then

WardBrian avatar Feb 27 '23 15:02 WardBrian