ExtraPlanets icon indicating copy to clipboard operation
ExtraPlanets copied to clipboard

"View Bobbing" Affects Moons/Stars On Jupiter

Open TheRealDannyyy opened this issue 6 years ago • 8 comments

---Issue Report---

Description of Issue

I've noticed a minor visual issue with some moons/stars, that can be seen in the skies of Jupiter. The view bobbing effect seems to affect them and make them "bobble" around while walking.

Steps to Reproduce Issue

  1. Enable "view bobbing" setting
  2. Visit Jupiter
  3. Notice moon/star bobbing around (only a few of them)

Crash log/Log (if applicable): On request if really required.

Screenshots (if applicable): On request if really required.

Version of Mod using (PLEASE DONT USE 'Latest' OR 'Newest'):

  • MinecraftForge v14.23.5.2815
  • ExtraPlanets-1.12.2-0.4.9
  • Galacticraft-Planets-1.12.2-4.0.2.190
  • MicdoodleCore-1.12.2-4.0.2.190
  • ExtraPlanets-1.12.2-0.4.9
  • MJRLegendsLib-1.12.2-1.1.8
  • jei_1.12.2-4.15.0.269
  • OptiFine_1.12.2_HD_U_E3

(Server is using exactly the same versions.)

Where did this bug happen: Dedicated Nitrado server with connected clients.

TheRealDannyyy avatar Mar 24 '19 00:03 TheRealDannyyy

Does it do it for moon and mars and venus?

MJRLegends avatar Mar 24 '19 07:03 MJRLegends

From what I could see (difficult repro because of #412), the following planets/moons/stars are affected: (1 is bobbing the most and 3 the least, not sure why the intensity is different for each one.) BobbingExample

TheRealDannyyy avatar Mar 24 '19 16:03 TheRealDannyyy

Thats not what i meant by does it happen on the moon and venus and mars. I meant the dimensions not the sky. As i believe its the same code they use for there stars as i believe this is a Galacticraft bug too.

MJRLegends avatar Mar 24 '19 16:03 MJRLegends

Sorry for the misunderstanding. I couldn't reproduce it on those planets like I can on Jupiter. It could be more subtle to the point where it isn't noticeable but I'm not sure.

Could you maybe look into the code and further identify the cause? I assume that's not a problem for you, since you know how all the stuff works. I'll re-open another issue if Extraplanets is indeed not the cause.

TheRealDannyyy avatar Mar 24 '19 16:03 TheRealDannyyy

I dont think it is the cause as ive seen people report this before. I will look at it though

MJRLegends avatar Mar 24 '19 17:03 MJRLegends

Maybe this will help when investigating.

While landing, some planets/moons seem to be too closely "attached" to the players view. Seems like they are more like sprites, instead of static elements you can see in the sky. Although that might just be the way Minecraft works, don't know how the whole skybox system works in detail.

TheRealDannyyy avatar Apr 20 '19 23:04 TheRealDannyyy

Im not sure how to fix sorry

MJRLegends avatar Aug 10 '20 15:08 MJRLegends

If any one wants to make a pull request to fix please do i will be grateful

MJRLegends avatar Aug 10 '20 15:08 MJRLegends