Compiling plugin for Zeek 5.0.1 - BroString.h: No such file or directory

[Psibur]

Manually compiling the plugin for 5.0.1 and receiving the error below. I only used the basic configure option to point to the bro-dist directory which has worked in prior versions of bro. Compiling on RHEL8 with the latest versions installed of the required packages (can list package versions if necessary):

./configure --bro-dist=/opt/src/zeek-5.0.1/

(snip)
[ 21%] Building CXX object CMakeFiles/mitrecnd-HTTP2.linux-x86_64.dir/src/Plugin.cc.o
In file included from /opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/src/HTTP2_Stream.h:10,
                 from /opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/src/HTTP2.h:19,
                 from /opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/src/Plugin.cc:2:
/opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/src/HTTP2_HeaderStorage.h:6:10: fatal error: BroString.h: No such file or directory
 #include "BroString.h"
          ^~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/mitrecnd-HTTP2.linux-x86_64.dir/build.make:114: CMakeFiles/mitrecnd-HTTP2.linux-x86_64.dir/src/Plugin.cc.o] Error 1
make[3]: Leaving directory '/opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/build'
make[2]: *** [CMakeFiles/Makefile2:124: CMakeFiles/mitrecnd-HTTP2.linux-x86_64.dir/all] Error 2
make[2]: Leaving directory '/opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/build'
make[1]: *** [Makefile:166: all] Error 2
make[1]: Leaving directory '/opt/src/zeek-5.0.1/aux/plugins/bro-http2-master/build'
make: *** [Makefile:13: build-it] Error 2

[awelzel]

Hey @Psibur - are you sure you had been using the latest master version when attempting to compile?

The line erroring in the output you show doesn't use BroString.h in master anymore. It uses "zeek/ZeekString.h":

https://github.com/MITRECND/bro-http2/blob/7dc14042d1602065d60601d193b99b005f08fe34/src/HTTP2_HeaderStorage.h#L6

Maybe you forgot to fetch/pull?