wfdb-python icon indicating copy to clipboard operation
wfdb-python copied to clipboard

Fix: Indent code to ensure 'j' is within for-loop in GQRS algorithm

Open Biboulder opened this issue 1 year ago • 1 comments

The variable j was not properly scoped within the for-loop in the sm method, leading to an UnboundLocalError when j was accessed outside the loop.

Biboulder avatar Jun 06 '24 21:06 Biboulder

@Biboulder Thanks for picking this up! Please could you rebase the pull request on the main branch, and if possible add a simple test that covers the UnboundLocalError?

tompollard avatar Jul 03 '24 19:07 tompollard

I rebased on main and opened a new PR: https://github.com/MIT-LCP/wfdb-python/pull/499

tompollard avatar Jul 09 '24 21:07 tompollard