mimic-iv/concepts: fix `postgres-make-concepts` and minor updates

[schu]

Please see the individual commits for context.

[alistairewj]

Thanks for the changes (and the other ones as well!). Which OS are you running this on? For the regexes, they are quite brittle as I'd like to support two common flavours of shell:

• BSD sed and bash 3.x (shipped on Mac OS X)
• GNU sed and bash 4.x+ (shipped on Ubuntu)

Trying to allow for this compatibility eliminates the possibility of using some common syntax.

[schu]

Which OS are you running this on?

Fedora 36 with Postgres 14.3 (the latest version in dnf).

[schu]

Hey, any news? :)

I'd be happy to get rid of the perl regex

If you want, I can test and push an alternative patch and drop the regex.

[alistairewj]

I got way too distracted by other things and the MySQL container build - but yes especially with people running into issues (e.g. #1393) this should definitely be fixed... making some changes now

[alistairewj]

OK this looks to work well - the checks will fail since they're running on a fork which is unprivileged.. it's a TODO of mine to make PRs trigger a privileged workflow rather than trying to run the tests themselves.

I tested it locally and built all the tables successfully (BSD sed over here). @schu can you give convert_bigquery_to_postgres.sh and postgres-make-concepts.sql a run with the latest commits pulled down? If it works for you, then we should be good to merge.

[alistairewj]

I'll merge this as I'll test the functionality with gh actions