Catching exceptions on empty results

[chrisr3d]

Hi @M0un, I just merged the pull request containing your new module and did a few tests on it.

There is one issue I saw with the loop on search results, since you are iterating on the indexes, when the results are empty search_results[i] will raise an IndexError.

It would be great if you could fix it.

Do not hesitate to keep in touch with @Rafiot or me if you have any question (Also sorry I already fixed some indentation issues, so you will have to pull the origin into your fork :angel:)

[M0un]

Hello,

Thank you for giving me feedback so quickly ! I'll look out for this issue as soon as I can.

Le mer. 26 févr. 2020 à 14:16, Christian Studer [email protected] a écrit :

Hi @M0un https://github.com/M0un, I just merged the pull request containing your new module and did a few tests on it.

There is one issue I saw with the loop on search results, since you are iterating on the indexes, when the results are empty search_results[i] will raise an IndexError.

It would be great if you could fix it.

Do not hesitate to keep in touch with @Rafiot https://github.com/Rafiot or me if you have any question (Also sorry I already fixed some indentation issues, so you will have to pull the origin into your fork 👼)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MISP/misp-modules/issues/375?email_source=notifications&email_token=AGOQIUPVKVXGXTIEKJ7TWTDREZTSVA5CNFSM4K4FCOOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQOFGHQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGOQIUPUCTX2JIEDFAIGYQTREZTSVANCNFSM4K4FCOOA .