misp-galaxy icon indicating copy to clipboard operation
misp-galaxy copied to clipboard

MITRE Engage Galaxy created

Open th3r3d opened this issue 1 year ago • 11 comments

I tried my best to create MISP Galaxy for MITRE Engage. More can be seen at https://engage.mitre.org

th3r3d avatar Aug 20 '24 14:08 th3r3d

Thank you very much @th3r3d . It looks like there is still an issue. The tests complain about parse error: Expected separator between values at line 4, column 16 It looks like a comma is missing at line 3.

Can you have a quick look and fix it?

Before running, please run the ./jq_all_the_things.sh and ./validate_all.sh.

Also make sure to re-generate the readme: update_README_with_index.py.

Lastly, would you be open to also share the script you used to generate this galaxy? This should allow us to re-generate it in the future whenever there are updates in MITRE Engage.

If all works well with above scripts, tests should run fine. All the best !

cvandeplas avatar Aug 20 '24 14:08 cvandeplas

I did all script checks, but Im not able to do update README. You were right on line 3 was missing comma. I will try later on linux machine, it maybe some mac thing. Script is here, but little bit messy (you need engage xlxs from : Download): https://github.com/th3r3d/scripts/blob/main/Python/engage-2-MISP.py

th3r3d avatar Aug 20 '24 15:08 th3r3d

I did came through all checks (fix few more typos and unsupported values) and get OK message with, but Im not able to run update README script.

th3r3d avatar Aug 20 '24 17:08 th3r3d

All right finally - all done now. Thanks for patience

th3r3d avatar Aug 20 '24 17:08 th3r3d

@th3r3d Can you review the PR to make the test pass? Thanks a lot.

adulau avatar Sep 19 '24 08:09 adulau

ERROR: Please commit your changes, and make sure you run ./jq_all_the_things.sh before committing. ;-)

adulau avatar Sep 19 '24 13:09 adulau

I see some files from your Python env in this pull-request ;-) Can you remove all those files? or do another PR?

adulau avatar Oct 15 '24 14:10 adulau

Will do new PR

th3r3d avatar Oct 30 '24 11:10 th3r3d

Done

th3r3d avatar Oct 30 '24 11:10 th3r3d

Thank you. Can you remove the files which are not related https://github.com/MISP/misp-galaxy/pull/1013/files ? or do a clean pull-request. I really would like to merge it.

adulau avatar Jan 24 '25 21:01 adulau

Hope, I finally got it work

Snímek obrazovky 2025-01-27 v 17 45 27

th3r3d avatar Jan 27 '25 16:01 th3r3d

Any news for the updated PR? Thanks a lot.

adulau avatar Jun 30 '25 13:06 adulau

I'll do new PR on weekend together with ADS object update.

th3r3d avatar Jul 03 '25 08:07 th3r3d