MITRE Engage Galaxy created
I tried my best to create MISP Galaxy for MITRE Engage. More can be seen at https://engage.mitre.org
Thank you very much @th3r3d .
It looks like there is still an issue. The tests complain about parse error: Expected separator between values at line 4, column 16
It looks like a comma is missing at line 3.
Can you have a quick look and fix it?
Before running, please run the ./jq_all_the_things.sh and ./validate_all.sh.
Also make sure to re-generate the readme: update_README_with_index.py.
Lastly, would you be open to also share the script you used to generate this galaxy? This should allow us to re-generate it in the future whenever there are updates in MITRE Engage.
If all works well with above scripts, tests should run fine. All the best !
I did all script checks, but Im not able to do update README. You were right on line 3 was missing comma. I will try later on linux machine, it maybe some mac thing. Script is here, but little bit messy (you need engage xlxs from : Download): https://github.com/th3r3d/scripts/blob/main/Python/engage-2-MISP.py
I did came through all checks (fix few more typos and unsupported values) and get OK message with, but Im not able to run update README script.
All right finally - all done now. Thanks for patience
@th3r3d Can you review the PR to make the test pass? Thanks a lot.
ERROR: Please commit your changes, and make sure you run ./jq_all_the_things.sh before committing. ;-)
I see some files from your Python env in this pull-request ;-) Can you remove all those files? or do another PR?
Will do new PR
Done
Thank you. Can you remove the files which are not related https://github.com/MISP/misp-galaxy/pull/1013/files ? or do a clean pull-request. I really would like to merge it.
Hope, I finally got it work
Any news for the updated PR? Thanks a lot.
I'll do new PR on weekend together with ADS object update.