Allow REDIS Password and ZMQ Switch

Open christianmg99 opened this issue 1 year ago • 2 comments

This code change allows for 2 new optional env variables REDIS_PASSWORD and ZMQ_ENABLE. Current deployments without these variables aren't affected.

May 02 '24 19:05 christianmg99

Not sure whether redis password is correctly loaded from docker-compose. ~~Anyway ZMQ and redis password are two different concerns, so it would make sense to split the PR.~~

May 02 '24 19:05 ostefano

LGTM, but we should have the env vars documented inside template.env, and picked up and forwarded to the container in the docker-compose.yml file as well.

Also misp-modules needs to pick up the password as well.

May 03 '24 12:05 ostefano

This PR would solve https://github.com/MISP/misp-docker/issues/9

Jun 01 '24 13:06 ostefano

Broke as is, https://github.com/MISP/misp-docker/pull/107 supersedes it

Aug 12 '24 09:08 ostefano