mipt-mips icon indicating copy to clipboard operation
mipt-mips copied to clipboard

Added operation logging to JSON

Open pavelkryukov opened this issue 4 years ago • 2 comments

Rebased from #1451

Now when you want to log operations to JSON file - you need to add flag -j or --json-dump and logs will be saved to your current directory to file "logs.json".

pavelkryukov avatar Feb 05 '21 19:02 pavelkryukov

Codecov Report

Merging #1452 (ace7f64) into main (dfc125c) will decrease coverage by 0.46%. The diff coverage is 63.04%.

:exclamation: Current head ace7f64 differs from pull request most recent head 015a2f4. Consider uploading reports for the commit 015a2f4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
- Coverage   99.78%   99.31%   -0.47%     
==========================================
  Files         141      141              
  Lines       11654    11542     -112     
==========================================
- Hits        11629    11463     -166     
- Misses         25       79      +54     
Impacted Files Coverage Δ
simulator/infra/ports/module.h 95.00% <ø> (-0.24%) :arrow_down:
simulator/modules/core/perf_sim.h 100.00% <ø> (ø)
simulator/infra/log.cpp 91.66% <50.00%> (-8.34%) :arrow_down:
simulator/modules/decode/decode.cpp 97.26% <50.00%> (-1.34%) :arrow_down:
simulator/modules/execute/execute.cpp 97.05% <50.00%> (-2.95%) :arrow_down:
simulator/modules/fetch/fetch.cpp 96.66% <50.00%> (-1.60%) :arrow_down:
simulator/modules/mem/mem.cpp 96.00% <50.00%> (-4.00%) :arrow_down:
simulator/modules/core/perf_sim.cpp 93.00% <53.33%> (-7.00%) :arrow_down:
simulator/func_sim/operation.h 96.42% <66.66%> (-2.88%) :arrow_down:
simulator/modules/writeback/writeback.cpp 97.36% <75.00%> (-2.64%) :arrow_down:
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfc125c...015a2f4. Read the comment docs.

codecov[bot] avatar Feb 05 '21 20:02 codecov[bot]

@andreyess I ran these changes locally and an output JSON file was not finalized. I made few comments how to improve code and resolve that issue, if you have time you may take a look. Unit tests would be very useful to guarantee stable behavior.

pavelkryukov avatar Feb 07 '21 12:02 pavelkryukov