OCTIS icon indicating copy to clipboard operation
OCTIS copied to clipboard

Update dependencies

Open Yfke opened this issue 1 year ago • 3 comments

Due to its very specific dependency requirements (exactly equal to specific subversions), this library is starting to become incompatible with other libraries in the ML space. I propose to follow the convention of only requiring a specific major version, and allowing the package manager freedom to decide on the minor version. I don't see specific reasons why OCTIS is not compatible with higher minor versions of gensim, scikit-learn and numpy.

Yfke avatar Dec 28 '23 09:12 Yfke

Thank you for reviewing and approving these changes. I do not have write access to this repo, so I cannot perform the merge myself.

Yfke avatar Feb 21 '24 08:02 Yfke

I am also facing an issue with the dependencies, and this PR seems to solve them. I think it would solve #114 as well. @silviatti, if you have a moment, can you have a look and merge it? Thanks a lot!

alex-spok avatar Apr 11 '24 15:04 alex-spok

Speaking up again to sa that I am facing this issue and merging this PR would be really helpful! @silviatti or @pietrotrope could you please have a look at this.

I excited to be able to try this properly in my project.

1jamesthompson1 avatar May 15 '24 04:05 1jamesthompson1

@silviatti or @pietrotrope

Can we please merge this PR?

alihashaam avatar Jul 22 '24 13:07 alihashaam

Hey everyone, thank you for your patience. I couldn't merge this PR because the tests were failing. However, I have fixed the dependencies in a separate branch and merged this into master today (pip install octis==1.14.0 should do the trick). Please let me know if have any issues with the dependencies and I'll try to address them. Finding the right combination wasn't trivial :) I'll close this PR for now

silviatti avatar Jul 22 '24 14:07 silviatti