MHKiT-MATLAB icon indicating copy to clipboard operation
MHKiT-MATLAB copied to clipboard

DOLfYN Functionality

Open rpauly18 opened this issue 4 years ago • 2 comments

Replicate DOLfYN IO functionality similarly to https://github.com/MHKiT-Software/MHKiT-Python/pull/126

rpauly18 avatar Oct 04 '21 21:10 rpauly18

Preference would be for pure Matlab (no wrapping python)

Alex-McVey avatar Jan 03 '22 20:01 Alex-McVey

We are actively working on completing DOLfYN functionality.

High Level Progress:

  • Reading Files:
  • Coordinate System Conversion
    • [X] dolfyn/euler2orient.m
    • [X] dolfyn/orient2euler.m
  • Rotation (dolfyn/rotate)
    • [X] Add rotation functionality
      • [ ] Track specific rotation functionality

PR #108 commit d29d5e3abbf743590652fe18567f1f3735a66ce4 adds the following:

Current code coverage indicates the following files have 0% code coverage:

  • [ ] dolfyn/adp/*.m
  • [ ] dolfyn/io/read_h5.m
  • [ ] dolfyn/io/write_netcdf.m
  • [ ] dolfyn/tools/bluewhitered.m
  • [ ] dolfyn/tools/dolfyn_plot.m

Dolyfn tests in MHKiT-Python that do not exist in MHKiT-MATLAB:

  • [ ] dolfyn/test_analysis
  • [ ] dolfyn/test_api
  • [ ] dolfyn/test_clean
  • [ ] dolfyn/test_motion
  • [ ] dolfyn/test_shortcuts
  • [ ] dolfyn/test_time
  • [ ] dolfyn/test_tools
  • [ ] dolfyn/test_vs_nortek

It may be the case that we do not need to add all of these tests, this is just for awareness and visibility.

simmsa avatar Jan 31 '24 19:01 simmsa