Menno Fraters
Menno Fraters
Thanks for the review! I have addressed your initial comments :)
Now that #4978 is merged, I have rebased this pull request to the current main branch. It should now be fully ready.
Yes, test are in the planning, and @srivatsvyas has already done some of the testing because the drexpp branch is based on this version instead of the paper version. I...
Thanks for your work on this and making this pull request @YiminJin! I looked over the changes, and they look reasonable to me, but I am not very familiar with...
> But I don't understand the meaning of "add to commit which updates the tester results" when you run the tests locally, you will notice that a lot of test...
@gassmoeller I added lcov to the docker file as discussed.
ah, sorry. Fixed it.
I am not saying we should not document it elsewhere as well, but there is already some documentation in the wiki: https://github.com/geodynamics/aspect/wiki/Indenting-code-and-installing-the-correct-version-of-astyle
Do we need to put this anywhere besides the wiki? If so, this would be a good starter project.
This pull request is now ready for review. Before making the world builder 0.6 release, I would like preliminary approval on this pull request that this is in principle good...