Menno Fraters
Menno Fraters
Thanks again for the quick review! hmm, I am fine with adding a changelog for this if you think it is important, but this pull request just adds some core...
Ah, sorry. I totally forgot, and did not check, that there was already a clang tidy. Sorry about that. Integrating it into the ci would be nice. The advantage of...
Hey @tjhei, Thanks for the review! I think I have addressed all your comments. Based on some of your comments I realized that it would probably be better to do...
@tjhei I have addressed your comments. I removed some of the repetition in the description of the enum and added some text to explain the difference between the deformation type...
> Can you please at least add one test model that uses the new functionality. In particular there were typos in input parameters that were not caught, because no test...
> (the existing tests use the passive case without fabric evolution). There is a unit test which tests 2 different computations of the derivatives with an actual fabric (one of...
@gassmoeller Thanks for the review! I have addressed all your comments. I have left the comment I thought would be good for you to read if my reply is satisfactory...
Now that #4978 is merged, I have rebased this pull request to the current main branch. It should now be fully ready.
> Just for my understanding: Is this essentially a copy of the particle postprocessor, except it does only process the CPO particle properties in a special way before outputting these...