Menno Fraters

> Does this work with unity builds? Do we need to set CMAKE_UNITY_BUILD for WB if ASPECT_UNITY_BUILD is on? Yes, I actually did most of my testing with unity build....

I don't really feel strongly about it. It would be nice if it would just compile the whole thing as a library (and have the tools as executables), but the...

Thanks again for the review. I addressed all your comments. Based on your review, there are just two outstanding issues in my mind: 1. Should CPO in 2D be allowed?...

@bobmyhill I have disabled both. It will be easier to loosen restrictions than to make it stricter. I have put the asserts in the parse parameters, which I think should...

@gassmoeller Thanks for the review! I have addressed your comments and left a few discussions unresolved. I also found that one of the variables in the advection scheme is not...

@gassmoeller Thanks for the review. I have addressed you comments. > You currently copy all properties from its storage location into new vectors in pack/unpack_data only because you can access...

@gassmoeller I rebased as discussed. Let me know if you have any other comments. @bobmyhill since your review status is still on changes requested, can I request a re-review? Thanks!

I am not sure what happened, because I am sure I had work on a version in which I removed the pack and unpack functions (which I thought I put...

@gassmoeller Thanks for the review. I have addressed your comments :)

Thanks for the quick review! I have addressed your comments :)