LegendaryExplorer icon indicating copy to clipboard operation
LegendaryExplorer copied to clipboard

Feature: Auto-add common properties to sequence objects

Open Mgamerz opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Adding certain object types to kismet is pretty annoying in LEX, such as adding a 'SeqAct_ActivateRemoteEvent'. You will always add the EventName property - it'd be nice if this was just auto populated to a sensible default, such as None. Some things already do this like SeqVar_Int.

Describe the solution you'd like Auto-add the property or prompt the user for one on object generation (e.g. name for EventName)

Describe alternatives you've considered I've done it manually and it's tedious to always have to add basic properties that always get used

Additional context N/A

Mgamerz avatar May 26 '22 23:05 Mgamerz

SeqVars have their properties auto-populated since there's only couple dozen of them, so it was simple enough to figure out the right defaults for all of them. There's a lot of Events, Actions, and Conditions though. The problem is figuring out the right defaults for all of them (or for whatever subset you want to support.) But once you know which objects you want to add defaults for it's simple to do. You'd want to add them here, right after the empty link removal code. Just add a classname switch there like I did for the SeqVars: https://github.com/ME3Tweaks/LegendaryExplorer/blob/5332779bd592394c9c9bafc94b77af66aa107620/LegendaryExplorer/LegendaryExplorerCore/Kismet/SequenceObjectCreator.cs#L131

SirCxyrtyx avatar May 27 '22 00:05 SirCxyrtyx

Something to remember when doing this, is that you should check all three games to ensure your defaults are correct for them all. It's usually the same, but as an example where it mattered: https://github.com/ME3Tweaks/LegendaryExplorer/blob/5332779bd592394c9c9bafc94b77af66aa107620/LegendaryExplorer/LegendaryExplorerCore/Kismet/SequenceObjectCreator.cs#L178-L184 BioSeqVar_ObjectFindByTag's m_sObjectTagToFind is a String in 1&2, but a Name in 3

SirCxyrtyx avatar May 27 '22 01:05 SirCxyrtyx