tedana icon indicating copy to clipboard operation
tedana copied to clipboard

inconsistent version numbers

Open handwerkerd opened this issue 2 years ago • 3 comments

Summary

@jbteves @n-reddy and I are working on comparing results between branches. When we type tedana --version on the same branch we all get the same hash but different version numbers.

Additional Detail

For example, the three of us are all looking at https://github.com/jbteves/tedana/tree/JT_DTM/ which is #756. Our outputs for tedana --version are: Josh: tedana v0.0.11+44.ge60f87a Dan: tedana v0.0.11rc1+53.ge60f87 Neha: tedana v0.0.12+34.ge60f87a

Assuming we are all looking at the same code, my best guess is that the hash is correct, but _version.py is somehow holding onto the version number from when the repo was last cloned. For both Josh & me our Main is synced with Main well after the v0.0.12 release.

Next Steps

  • @emdupre @tsalo know this part of the code best. Does one of you have the time to try to figure out why this might be happening?

handwerkerd avatar Sep 13 '22 15:09 handwerkerd

Maybe try updating the tags

git fetch --all --tags

and then seeing how the version updates

notZaki avatar Sep 13 '22 19:09 notZaki

That updated the version number for me. Thank you! Is there a way to update the tags when people pull or is this just inherent to the way github/git is set up?

handwerkerd avatar Sep 13 '22 19:09 handwerkerd

That could be accomplished if each user edits their own git config, as described in this post, but I don't think there's a way for us to change how git pull behaves for users.

In any case, the hash is what ultimately matters in the version number, so as long as that matches, it's all good.

notZaki avatar Sep 13 '22 20:09 notZaki