tedana icon indicating copy to clipboard operation
tedana copied to clipboard

[MAINT] Add 3.10 unit test, compatibilities in info.py

Open jbteves opened this issue 3 years ago • 6 comments

Closes #817 .

Changes proposed in this pull request:

  • Adds 3.10 Support, testing

jbteves avatar Oct 15 '21 13:10 jbteves

In NiMARE trying out Python 3.10 failed. I don't even know what's happening here... Why would it freeze like that?

tsalo avatar Oct 15 '21 15:10 tsalo

It appears it was trying to download many copies of many packages... I'm not sure. I'm willing to wait a bit and simply push a blank commit to see if it is resolved in perhaps a month.

jbteves avatar Oct 15 '21 18:10 jbteves

It looks like v1.21.4 supports 3.10.

tsalo avatar Nov 16 '21 17:11 tsalo

It looks like SciPy 1.8 may now support Python 3.10. Worth confirming? https://docs.scipy.org/doc/scipy/release.1.8.0.html

handwerkerd avatar Feb 17 '22 03:02 handwerkerd

No dice.

jbteves avatar Feb 17 '22 12:02 jbteves

I think this might be worth another check. Can you update from main?

tsalo avatar Aug 12 '22 14:08 tsalo

Finally passes, now that we have 3.11!

jbteves avatar Nov 16 '22 22:11 jbteves

Codecov Report

Base: 93.30% // Head: 93.30% // No change to project coverage :thumbsup:

Coverage data is based on head (11f3224) compared to base (0879a94). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          28       28           
  Lines        2345     2345           
=======================================
  Hits         2188     2188           
  Misses        157      157           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Nov 16 '22 22:11 codecov[bot]