tedana icon indicating copy to clipboard operation
tedana copied to clipboard

Minimum image regression relies on distinction between "accepted" and "ignored" components

Open tsalo opened this issue 1 year ago • 1 comments

Summary

I'm working on refactoring the global signal regression functions in order to better understand them (particularly for #1071), and I noticed that gscontrol.minimum_image_regression specifically uses "accepted" components and not "ignored" components. Since we eliminated the "ignored" classification in #756, MIR likely doesn't work the way it was intended anymore.

We could probably leverage the classification tags, but those vary by decision tree and are essentially up to the user.

tsalo avatar Apr 21 '24 15:04 tsalo

Ah, I see that "low variance" and "accept borderline" only exist as classification tags in the meica and tedana_orig trees.

tsalo avatar Apr 29 '24 14:04 tsalo