Max Dörner

Results 62 comments of Max Dörner

I cannot reproduce this with the latest build. Is this still happening with the latest prerelease?

The additional point is basically the topic of #5910 .

This has been introduced with the PR bringing the reference nodes to the CE. The problem is that it is still trying to get the reference information from the VBE...

The quickfix will be really easy once we have implemented _extract method_; it just needs to make the method private and then use the refactoring action.

We actually only parse the form headers in order not to fail on them. Afterwards, we ignore that part of the parse tree. The current grammar's rules around forms are...

Oh, now I realize that you referred to the VBA grammar on the Antlr repo. I think we provided that at some point. However, our grammar at https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Parsing/Grammar/VBAParser.g4 has evolved...

By the way, our grammar assumes that precompiler directives are already taken care of. To do that we first parse with our precompiler parser https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Parsing/Preprocessing/VBAConditionalCompilationParser.g4, evaluate which code is dead...

Hm, one could see whether one can merge enhancements in.

The exception on shutdown is the same as in #6150. I think that is a separate issue.

This might actually have the same root cause as #5991. I will have a look. Thanks for the MCVE.