mdsplus icon indicating copy to clipboard operation
mdsplus copied to clipboard

There are 22 TDI function files that need spaces around the ".." range symbol

Open mwinkel-dev opened this issue 1 year ago • 0 comments

Affiliation MIT PSFC

Version(s) Affected Found in current Alpha, but affects all versions.

Platform All platforms

Describe the bug As described in PR #2669, changes were made to TDI's lexical analyzer some time ago that affect parsing of the ".." range symbol. And thus it now needs to be written with spaces, " .. ".

A scan of the source code found 22 TDI *.fun files that use the old ".." and thus need to be upgraded.

findsig_multi.fun
pseudo.fun
ptdata2.fun
pthead2_size.fun
I6810__init.fun
Amplitude_M0.fun
Amplitude_M1.fun
Amplitude_M2.fun
baseline_segmented.fun
BoloInit.fun
bRadField2D.fun
FastCamTriggerCheck.fun 
MCAMERA__store.fun
NI6071E__add.fun
pulseCheck_MHD_CONFIG.fun
RfxLocControlConfig.fun
RfxModeControlConfig.fun
RfxTempPolTor.fun
RfxVirtualShellConfig.fun
TSEdgeCCD__store.fun
TSEdgeCCDGridSignal.fun

To Reproduce To generate the list of files, use regular expressions to search all .fun files for [_\$A-Za-z0-9]+\.\.[_\$A-Za-z0-9]+. Note that it might be necessary to use some variants of this search expression to find all lines that need to be updated.

Expected behavior n/a

Screenshots n/a

Additional context It appears that most (all?) of the above TDI functions are associated with "devices". Priority should probably be given to any *.fun files that are in the tdi/math directory.

mwinkel-dev avatar Jan 02 '24 17:01 mwinkel-dev