mdsplus icon indicating copy to clipboard operation
mdsplus copied to clipboard

MDSplus kits loose version information

Open joshStillerman opened this issue 3 years ago • 3 comments

We have seen this before, but it keeps happening. The current version of mdsplus-alpha alpha_release-7-134-15 shows version 0.0.0 when asked:

jas@mfews07:~/mdsplus$ mdstcl
TCL> show version


MDSplus version: 0.0.0
----------------------
  Release:  alpha_release_0.0.0
  Browse:   https://github.com/MDSplus/mdsplus/tree/alpha_release_0.0.0
  Download: https://github.com/MDSplus/mdsplus/archive/alpha_release_0.0.0.tar.gz

joshStillerman avatar Nov 04 '21 17:11 joshStillerman

I looked through the code, and can not see how this works.

joshStillerman avatar Nov 04 '21 18:11 joshStillerman

damn.. well i made it so straight forward as I could, removing most of the configure.ac logic .. The magic should now happen in ./deploy/git_revision.sh. It should be executed by the main builder during bootstrapping and write the configure bits that simply sets those variables. not sure why it would not work.. i may find some time next week ..

zack-vii avatar Nov 05 '21 00:11 zack-vii

When I build it in my own directory, it does the right thing. When I fire off a build using jenkins (for example: http://jenkins2.mdsplus.org/job/ubuntu18/7846/console ) it seems to know what version it is building but does not put that version information where it needs to be.

joshStillerman avatar Nov 08 '21 17:11 joshStillerman

Haven't seen this in a while, we'll keep an eye on it.

WhoBrokeTheBuild avatar Mar 30 '23 19:03 WhoBrokeTheBuild