Remove `--fast-math` from compile flags?
Based on recent issues highlighted on denormals behaviour, do we want to just get rid of that flag?
What is the performance hit for getting rid of it? But since it is contagious, we probably want to remove it.
After having read through all of the stuff that @lilyminium had posted, I am in favor of removing it.
Just for the sake of it, I did run the script for the article.
While we do reference the -ffast-math option, the script did not find any issue. This makes it difficult for me to assess the effectiveness of a fix.
For the record, this is what I did:
pip install -e ./package/
python ~/src/fast_check_for_ffast_math.py $(find ./ -name '*.so')
I should add that we are not in the list compiled as part of the article: https://moyix.net/~moyix/ffast_summary.html
Also, we need to make sue we do not introduce a regression about #2722.