mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Remove `--fast-math` from compile flags?

Open IAlibay opened this issue 3 years ago • 5 comments

Based on recent issues highlighted on denormals behaviour, do we want to just get rid of that flag?

IAlibay avatar Sep 09 '22 13:09 IAlibay

What is the performance hit for getting rid of it? But since it is contagious, we probably want to remove it.

jbarnoud avatar Sep 09 '22 13:09 jbarnoud

After having read through all of the stuff that @lilyminium had posted, I am in favor of removing it.

orbeckst avatar Sep 13 '22 23:09 orbeckst

Just for the sake of it, I did run the script for the article.

While we do reference the -ffast-math option, the script did not find any issue. This makes it difficult for me to assess the effectiveness of a fix.

For the record, this is what I did:

pip install -e ./package/
python ~/src/fast_check_for_ffast_math.py $(find ./ -name '*.so')

jbarnoud avatar Sep 14 '22 18:09 jbarnoud

I should add that we are not in the list compiled as part of the article: https://moyix.net/~moyix/ffast_summary.html

jbarnoud avatar Sep 14 '22 18:09 jbarnoud

Also, we need to make sue we do not introduce a regression about #2722.

jbarnoud avatar Sep 14 '22 18:09 jbarnoud