mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Make Cython a build requirement

Open IAlibay opened this issue 3 years ago • 6 comments

We've been saying we'd do this for ages but never go around to it.

Making Cython required at build time (which is sorta is because of pyproject.toml) would make deployment life a lot easier.

Are there any downsides here? Do we maybe need to pin to a very specific Cython version on release or can we assume it should be fine as long as it's more or less in the right range?

IAlibay avatar Aug 29 '22 21:08 IAlibay

I think we've always been waiting for v3.0 (i.e. semver stable) to be released. That said, I don't think a) we're using cython too "aggressively" such that it would break version to version and b) cython has never given us troubles wrt versions. It's probably fine just to have cython as a build requirement

richardjgowers avatar Aug 29 '22 21:08 richardjgowers

@IAlibay shall I add this to the 3.0.0 milestone? Remove if you think it should be push back.

hmacdope avatar Nov 12 '22 01:11 hmacdope

Mayybe? I might revisit it for 2.5.0 tbh, it's only really affecting tarball installs at this rate I think.

IAlibay avatar Nov 12 '22 01:11 IAlibay

I think we've just been overlooking that Cython has been a build requirement since we've switched to having a pyproject.toml file. I'm going to put this as a 2.5.0 target, we should solve this before our setup.py ends up causing us actual trouble.

IAlibay avatar Dec 16 '22 01:12 IAlibay

Moving this to 2.6.0, there's a lot of setup.py stuff that needs untangling that won't be resolved yet.

IAlibay avatar Apr 27 '23 16:04 IAlibay

Adding to 3.0 board.

hmacdope avatar Oct 07 '23 05:10 hmacdope