mdanalysis
mdanalysis copied to clipboard
Type hints for topology module
Fixes #
Changes made in this Pull Request:
PR Checklist
- [ ] Tests?
- [ ] Docs?
- [ ] CHANGELOG updated?
- [ ] Issue raised/referenced?
Hello @umak1106! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
package/MDAnalysis/topology/DMSParser.py:
Line 222:1: W293 blank line contains whitespace Line 222:1: W391 blank line at end of file
- In the file
package/MDAnalysis/topology/GSDParser.py:
Line 128:80: E501 line too long (82 > 79 characters)
- In the file
package/MDAnalysis/topology/TOPParser.py:
Line 306:38: E251 unexpected spaces around keyword / parameter equals
Comment last updated at 2022-08-11 22:09:07 UTC
Codecov Report
Merging #3774 (091a662) into develop (6302b4c) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop #3774 +/- ##
========================================
Coverage 94.30% 94.31%
========================================
Files 192 192
Lines 24777 24788 +11
Branches 3341 3341
========================================
+ Hits 23367 23378 +11
Misses 1362 1362
Partials 48 48
| Impacted Files | Coverage Δ | |
|---|---|---|
| package/MDAnalysis/topology/CRDParser.py | 94.44% <100.00%> (ø) |
|
| package/MDAnalysis/topology/DLPolyParser.py | 96.59% <100.00%> (+0.03%) |
:arrow_up: |
| package/MDAnalysis/topology/DMSParser.py | 90.66% <100.00%> (+0.12%) |
:arrow_up: |
| package/MDAnalysis/topology/FHIAIMSParser.py | 100.00% <100.00%> (ø) |
|
| package/MDAnalysis/topology/GMSParser.py | 97.50% <100.00%> (ø) |
|
| package/MDAnalysis/topology/GROParser.py | 100.00% <100.00%> (ø) |
|
| package/MDAnalysis/topology/GSDParser.py | 93.75% <100.00%> (+0.13%) |
:arrow_up: |
| package/MDAnalysis/topology/LAMMPSParser.py | 96.26% <100.00%> (+0.03%) |
:arrow_up: |
| package/MDAnalysis/topology/MOL2Parser.py | 99.12% <100.00%> (ø) |
|
| package/MDAnalysis/topology/MinimalParser.py | 100.00% <100.00%> (ø) |
|
| ... and 9 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I would put that module on hold. @aya9aladdin is actively working on it so your work here is extremely prone to merge conflicts.