mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

type hints for Visualization module

Open umak1106 opened this issue 3 years ago • 3 comments

Fixes #

Changes made in this Pull Request:

PR Checklist

  • [ ] Tests?
  • [ ] Docs?
  • [ ] CHANGELOG updated?
  • [ ] Issue raised/referenced?

umak1106 avatar Jul 04 '22 11:07 umak1106

Hello @umak1106! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 161:80: E501 line too long (102 > 79 characters) Line 335:1: W293 blank line contains whitespace Line 336:1: W293 blank line contains whitespace

Comment last updated at 2022-08-20 21:58:10 UTC

pep8speaks avatar Jul 04 '22 11:07 pep8speaks

Codecov Report

Merging #3746 (72d42ec) into develop (c01d82b) will increase coverage by 0.00%. The diff coverage is 96.42%.

:exclamation: Current head 72d42ec differs from pull request most recent head 7e019dd. Consider uploading reports for the commit 7e019dd to get more accurate results

@@           Coverage Diff            @@
##           develop    #3746   +/-   ##
========================================
  Coverage    94.30%   94.30%           
========================================
  Files          192      192           
  Lines        24695    24777   +82     
  Branches      3327     3341   +14     
========================================
+ Hits         23289    23367   +78     
- Misses        1358     1362    +4     
  Partials        48       48           
Impacted Files Coverage Δ
package/MDAnalysis/visualization/streamlines_3D.py 96.19% <95.23%> (+0.02%) :arrow_up:
package/MDAnalysis/visualization/streamlines.py 93.51% <100.00%> (+0.06%) :arrow_up:
package/MDAnalysis/lib/formats/libmdaxdr.pyx 89.05% <0.00%> (-0.76%) :arrow_down:
package/MDAnalysis/core/topology.py 99.44% <0.00%> (-0.56%) :arrow_down:
package/MDAnalysis/core/topologyattrs.py 96.58% <0.00%> (-0.07%) :arrow_down:
package/MDAnalysis/units.py 100.00% <0.00%> (ø)
package/MDAnalysis/core/groups.py 98.58% <0.00%> (ø)
package/MDAnalysis/analysis/bat.py 97.59% <0.00%> (ø)
package/MDAnalysis/analysis/gnm.py 99.20% <0.00%> (ø)
package/MDAnalysis/analysis/msd.py 100.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 04 '22 11:07 codecov[bot]

Should the arguments for def update_dictionary_point_in_cube_start_frame(array_simulation_particle_coordinates,dictionary_cube_data_this_core): be Sequence[float] and Dict[float] ?

umak1106 avatar Jul 05 '22 08:07 umak1106