replacing usage of lib.util.which and adding decorator

[aditi2906]

Fixes #3649

Changes made in this Pull Request:

• Replaced usage of lib.util.which with shutil.which
• added decroator warnings

PR Checklist

• [x] Tests?
• [x] Docs?
• [ ] CHANGELOG updated?
• [x] Issue raised/referenced?

[pep8speaks]

Hello @aditi2906! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file testsuite/MDAnalysisTests/lib/test_util.py:

Line 53:1: E302 expected 2 blank lines, found 1 Line 54:60: E231 missing whitespace after ':' Line 59:1: E302 expected 2 blank lines, found 1 Line 61:60: E231 missing whitespace after ':' Line 68:1: E302 expected 2 blank lines, found 1 Line 177:80: E501 line too long (80 > 79 characters) Line 596:80: E501 line too long (82 > 79 characters) Line 598:80: E501 line too long (82 > 79 characters) Line 600:80: E501 line too long (82 > 79 characters) Line 602:80: E501 line too long (82 > 79 characters) Line 613:80: E501 line too long (82 > 79 characters) Line 615:80: E501 line too long (82 > 79 characters) Line 617:80: E501 line too long (82 > 79 characters) Line 619:80: E501 line too long (82 > 79 characters) Line 904:80: E501 line too long (80 > 79 characters) Line 974:80: E501 line too long (81 > 79 characters) Line 979:80: E501 line too long (81 > 79 characters) Line 980:80: E501 line too long (81 > 79 characters) Line 981:80: E501 line too long (81 > 79 characters) Line 998:80: E501 line too long (81 > 79 characters) Line 1002:80: E501 line too long (81 > 79 characters) Line 1017:80: E501 line too long (81 > 79 characters) Line 1238:80: E501 line too long (80 > 79 characters) Line 1243:80: E501 line too long (83 > 79 characters) Line 1254:80: E501 line too long (82 > 79 characters) Line 1277:80: E501 line too long (91 > 79 characters) Line 1320:80: E501 line too long (101 > 79 characters) Line 1322:80: E501 line too long (105 > 79 characters) Line 1324:80: E501 line too long (101 > 79 characters) Line 1326:80: E501 line too long (105 > 79 characters) Line 1514:37: E721 do not compare types, use 'isinstance()' Line 1562:80: E501 line too long (80 > 79 characters) Line 1656:80: E501 line too long (80 > 79 characters) Line 1858:80: E501 line too long (80 > 79 characters)

Comment last updated at 2022-07-05 19:29:07 UTC

[codecov[bot]]

Codecov Report

Merging #3667 (0db47ad) into develop (cf17d42) will increase coverage by 0.02%. The diff coverage is 78.57%.

@@             Coverage Diff             @@
##           develop    #3667      +/-   ##
===========================================
+ Coverage    94.30%   94.33%   +0.02%     
===========================================
  Files          192      192              
  Lines        24695    24698       +3     
  Branches      3327     3327              
===========================================
+ Hits         23289    23298       +9     
+ Misses        1358     1355       -3     
+ Partials        48       45       -3     

Impacted Files	Coverage Δ
package/MDAnalysis/analysis/legacy/x3dna.py	0.00% <0.00%> (ø)
package/MDAnalysis/lib/util.py	90.31% <78.57%> (-0.54%)	:arrow_down:
package/MDAnalysis/analysis/hole2/hole.py	82.93% <100.00%> (+0.04%)	:arrow_up:
package/MDAnalysis/analysis/hole2/utils.py	82.50% <100.00%> (+6.39%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf17d42...0db47ad. Read the comment docs.

[orbeckst]

@aditi2906 will you be able to complete the PR? There's not much else to do as far as I can tell.

[IAlibay]

Closing this PR as stale, please do re-open if you still wish to contribute!