mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Benchmarks for more lib.distances methods required

Open richardjgowers opened this issue 3 years ago • 9 comments

We need benchmarks for the following functions:

  • lib.distances.calc_bonds
  • lib.distances.calc_angles
  • lib.distances.calc_dihedrals

richardjgowers avatar Apr 03 '21 11:04 richardjgowers

I would like up this issue please provide some more literature on whats expected as an output.

RATED-R-SUNDRAM avatar Mar 10 '22 09:03 RATED-R-SUNDRAM

can you give a link to this repository I want to help with this

olivia632 avatar Mar 26 '22 03:03 olivia632

how can I help you create benchmarks for the following functions?

olivia632 avatar Mar 26 '22 03:03 olivia632

as we have a built-in function for this we can use Timeit @richardjgowers

timeit.Timer(lib.distances.calc_bonds).timeit(number=number)

as in here number we refer a number of times we want the function to be executed

import timeit runs_no= 10 duration = timeit.Timer(lib.distances.calc_bonds).timeit(number = runs_no) avg_dur = dur/runs_no #tells the average duration print('On average it took {avg_dur} seconds')

olivia632 avatar Mar 26 '22 04:03 olivia632

Hi @olivia632, when we talk about benchmarks in this context, we mean automated benchmarks run by asv. Please read the information here to get more info on how to write benchmarks for use with asv.

hmacdope avatar Mar 26 '22 05:03 hmacdope

thanks i got it @hugo

On Sat, Mar 26, 2022 at 11:17 AM Hugo MacDermott-Opeskin < @.***> wrote:

Hi @olivia632 https://github.com/olivia632, when we talk about benchmarks in this context, we mean automated benchmarks run by asv. Please read the information here https://github.com/MDAnalysis/mdanalysis/tree/develop/benchmarks to get more info on how to write benchmarks for use with asv.

— Reply to this email directly, view it on GitHub https://github.com/MDAnalysis/mdanalysis/issues/3205#issuecomment-1079613028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWJJLOIMFFMKIRLZM7RQDWDVB2QITANCNFSM42KFL37Q . You are receiving this because you were mentioned.Message ID: @.***>

olivia632 avatar Mar 28 '22 17:03 olivia632

https://asv.readthedocs.io/en/stable/writing_benchmarks.html can we do something with help of this

olivia632 avatar Mar 28 '22 18:03 olivia632

hello guys please i want to work on this issue, please can you help me with some detailed explanation of what am to do in other to solve it.

BertinAm avatar Mar 31 '22 05:03 BertinAm

@richardjgowers i am working on it.

manishsaini6421 avatar Apr 16 '22 08:04 manishsaini6421