MCreator icon indicating copy to clipboard operation
MCreator copied to clipboard

Multi Noise Settings

Open MISMASJETU opened this issue 2 years ago • 11 comments

So first thing, this is my first PR. Sorry beforehand if I messed something up.

What is this change about: -Right now mcreator handles multinoise using some formulas, however, this is not ideal for every user -There is now new window in biome mod element where you can configure the multi noise values.

What may need to change: -Maybe some help tips

Again, this is my first PR, so if I messed something up, I am sorry.

MISMASJETU avatar Jul 03 '22 20:07 MISMASJETU

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 03 '22 20:07 CLAassistant

Some more top-level comments:

  1. 1.16.5 has this totally different so this will need to wait until this generator is dropped
  2. For most users, these settings are too complex, so I would suggest changing this in this matter: remove existing parameters for temperature, humidity, and such. Keep these new. Make an FV converter to convert existing workspaces. Then make switchable input where users can enter settings like they are now and they would be calculated to new parameters and possibly vice versa. And then only new multi-noise settings would be stored.
  1. Yeah I get that. So this has to wait till 1.19/update when 1.16 is dropped right?
  2. Yeah, I kinda wanted to do it that way, for example, when you turn on the multi noise settings I added, it turns of some of the 1.16 features and keeps only temperature and chance of rain. But I get it needs to be its totally own thing.
  3. So what do you recommend I should do? Repair the problems now or wait until 1.16.5 is dropped?

MISMASJETU avatar Jul 04 '22 14:07 MISMASJETU

As you want, you can prepare UI now already

KlemenDEV avatar Jul 04 '22 15:07 KlemenDEV

You'll also need to make French and Russian help tips, and tests are missing!

I did not ask for French and Russian tips because he needs to fix and have the final version of English tips before we send him French and Russian versions.

Goldorion avatar Jul 04 '22 18:07 Goldorion

As you want, you can prepare UI now already

Well, I am going to propably wait until 1.19 generator is in development. (Am I allowed to ping you on discord when it starts or not?)

Meanwhile, there is one more thing I wanted to add and this one is actually a lot smaller.

MISMASJETU avatar Jul 04 '22 19:07 MISMASJETU

(Am I allowed to ping you on discord when it starts or not?)

You will see it being announced

KlemenDEV avatar Jul 06 '22 06:07 KlemenDEV

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs.

stale[bot] avatar Jul 30 '22 17:07 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs.

stale[bot] avatar Sep 08 '22 23:09 stale[bot]

@Goldorion So should I continue work on this? Or will someone else take it from here? I am not sure in what state is 1.19 support, I wasnt following the development news lately

MISMASJETU avatar Sep 21 '22 12:09 MISMASJETU

@KlemenDEV Well, to be honest, I will propably start over working on this, since this is built on extremely old version by now. Or is there some way I can safely update it to newest mcreator version? Still kinda new to branches and stuff.

MISMASJETU avatar Oct 06 '22 18:10 MISMASJETU

You can merge into your branch from master

KlemenDEV avatar Oct 07 '22 07:10 KlemenDEV

Is this PR even alive?

MagicalAlexey avatar Oct 27 '22 15:10 MagicalAlexey

Is this PR even alive?

Sorry, I dont have much time lately. I might get back to it later, but if anyone wants to take over be my guest.

MISMASJETU avatar Oct 27 '22 20:10 MISMASJETU