Minecraft 1.21.4

[drouarb]

Hello,

I updated to Minecraft 1.21.4/Sodium 0.6.9.

~~This update disable douira's sodium 0.6 translucency sorting to rely on nvidium's one.~~

Also, if you are lazy, beta builds here: https://github.com/drouarb/nvidium/releases

For issues go here https://github.com/drouarb/nvidium/issues Don’t spam the PR

Included in this PR:

• Update to Gradle 8.10
• Update to Minecraft 1.21.4
• Update for sodium 0.6
• New translucency sorting option "Sodium" relying on douira's translucency sorter
• Disabling sodium translucency sorting when the settings is not sodium
• Fixing Mipmaps to match sodium
• Fixing a rare crash due to Iris hijacking our NvidiumCompactChunkVertex
• Fixing instantReschedule to prevent it double scheduling chunks and crashing the game (maybe not fixed ?)

Known issues:

• https://github.com/drouarb/nvidium/issues/13 There is a race condition due to the facts that I store vertexCounts on chunk output to integrate transluscent data on sort output, but this can be inconsistent if a rebuild is triggered. Translucency data should be handled by mixin in the sorter but the sorter gives us per-facing index which is incompatible with how we store transluscent vertex data. The transluscent vertex data should be updated to work per facing. It will also be a problem when sodium 0.7 will be released since the facing order is not consistent anymore.
• https://github.com/drouarb/nvidium/issues/22 Unsure if it's nvidium fault, some people reported the crash without nvidium but unsure if it was on stable branch.

EDIT2:

• Sodium douira's translucency sorting is now implemented inside nvidium as an option. It will rely on sodium indexBuffer to sort translucent quads. Other options still remains available.
• Async BFS crashes have been fixed by preventing double scheduling a section build.

EDIT3:

• Everything should be working now
• There is still room for improvement, as douira mentioned, it would be more efficient to mixin into the sorter to make it generate a mesh indexBuffer

EDIT4: There's also a 1.21.5 &1.21.1 branchs, I can make PRs if needed.

[bearaujus]

This PR is very promising, can't wait this PR to be merged & released! I don't even understand what is happening on the files changed xD. Anw, thanks a lot @drouarb @MCRcortex @GrinlexGH 👍

[UrBoiTom]

Doesn't seem to work with the latest voxy rewrite build for some reason, probably an issue on Voxy's side considering the fact it's still in development but probably also worth looking into.

[wicivo]

the leaves started to look worse

[Quantum39]

if this is a comparison between sodium and nvidium, it is caused by douiras translucency sorter being disabled

[Felix14-v2]

Leaves aren't translucent, they are cutout and shouldn't be affected by the sorter.

[Latokes]

Sry but i dont really understand how to get it as a mod. Any help?

[ayushsucksaf]

Sry but i dont really understand how to get it as a mod. Any help?

here : https://github.com/drouarb/nvidium/releases its under assests

[KarmaMarazu]

It often happens that the chunk does not update automatically when making changes to the terrain, when forcing the update with "F3+A" the problem disappears. When the problem occurs, other chunks are not affected, only that specific chunk does not update.

Other mods used: DistantHorizons-fabric-2.3.0-b-dev-1.21.4 (Disabled) Sodium 0.6.10 Xaeros Minimap 25.1.0 Xaeros WorldMap 1.39.4

this is not what these reviews are for please use the forks issue's page instead

[MaxLevs]

this is not what these reviews are for please use the forks issue's page instead

It's a bug found in 1.21.4 build. And It was reported here berfore changes were merged. It must be here for everyone to take a look at it and decide if it's critical or not to merge. Or we don't care about any possible bugs?

Why is this supposed to be in fork's issues if nobody really care 'bout issues there? Are u going to visit that page to review if there are any reported bugs related to this update?

[adr278]

this is not what these reviews are for please use the forks issue's page instead

It's a bug found in 1.21.4 build. And It was reported here berfore changes were merged. It must be here for everyone to take a look at it and decide if it's critical or not to merge. Or we don't care about any possible bugs?

Why is this supposed to be in fork's issues if nobody really care 'bout issues there? Are u going to visit that page to review if there are any reported bugs related to this update?

you can report issues in here https://github.com/drouarb/nvidium/issues like everyone else, also:

[KarmaMarazu]

Are u going to visit that page to review if there are any reported bugs related to this update?

Ive looked at the page before but not fully because idk how this mod or these changes fully work. But yk who does? The person who made the fork they will look at the issues and have a better chance at fixing it then most people

[caiocinel]

It often happens that the chunk does not update automatically when making changes to the terrain, when forcing the update with "F3+A" the problem disappears. When the problem occurs, other chunks are not affected, only that specific chunk does not update. Other mods used: DistantHorizons-fabric-2.3.0-b-dev-1.21.4 (Disabled) Sodium 0.6.10 Xaeros Minimap 25.1.0 Xaeros WorldMap 1.39.4

this is not what these reviews are for please use the forks issue's page instead

I also think this should be the correct action, but it is often common for the owner to merge the pull request without noticing open issues in the fork, and doing this as a review makes it very clear that there are things to be done before this happens.

[wicivo]

It's still not fixed

[drouarb]

It's still not fixed

As mentionner previously, this is not an issue tracker, for issues go here https://github.com/drouarb/nvidium/issues

[sternschnaube]

Thanks for the update 😄

[copyandexecute]

Yees please do a 1.21.5 pr! appreciated