RetroMCP-Java icon indicating copy to clipboard operation
RetroMCP-Java copied to clipboard

Decompiling r1.1 with Modloader/ModloaderMP/Audiomod fails

Open mojontwins opened this issue 2 years ago • 4 comments

Decompiling a r1.1 minecraft.jar Client patched with Modloader/ModloaderMP/Audiomod fails at the beginning of the process with this error:

java.lang.StringIndexOutOfBoundsException: String index out of range: 35
	at java.lang.String.codePointAt(String.java:687)
	at org.mcphackers.rdi.injector.remapper.Remapper.remapSignature(Remapper.java:735)
	at org.mcphackers.rdi.injector.remapper.Remapper.remapSignature(Remapper.java:717)
	at org.mcphackers.rdi.injector.remapper.Remapper.remapField(Remapper.java:455)
	at org.mcphackers.rdi.injector.remapper.Remapper.process(Remapper.java:231)
	at org.mcphackers.rdi.nio.RDInjector.lambda$applyMappings$0(RDInjector.java:94)
	at org.mcphackers.rdi.nio.RDInjector.transform(RDInjector.java:80)
	at org.mcphackers.mcp.tasks.TaskDecompile.applyInjector(TaskDecompile.java:189)
	at org.mcphackers.mcp.tasks.TaskDecompile.lambda$setStages$1(TaskDecompile.java:72)
	at org.mcphackers.mcp.tasks.TaskStaged$Stage.doTask(TaskStaged.java:76)
	at org.mcphackers.mcp.tasks.TaskStaged$Stage.access$200(TaskStaged.java:60)
	at org.mcphackers.mcp.tasks.TaskStaged.doTask(TaskStaged.java:36)
	at org.mcphackers.mcp.tasks.Task.performTask(Task.java:65)
	at org.mcphackers.mcp.MCP.lambda$performTask$0(MCP.java:115)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

Patched JAR can be downloaded here: https://github.com/mojontwins/MC_Mods/raw/master/misc/minecraft.jar

mojontwins avatar Jun 08 '23 16:06 mojontwins

What RetroMCP version and java version are you using?

ghost avatar Jun 08 '23 16:06 ghost

Thanks for answering so soon. JDK 8 and latest RMCP release (1.0).

mojontwins avatar Jun 08 '23 17:06 mojontwins

Sorry - Audiomod / Modloader / ModloaderMP decompile just fine. The error happens when you add the Twilight Forest (1.6.2 for r1.1) to the mix. Maybe I'm not doing it the right way? I'm just adding TF to the main JAR even thought it is a modloader mod.

mojontwins avatar Jun 08 '23 18:06 mojontwins

You can open up the mod .jar in Recaf or Enigma and apply the mappings, the mod source should be readable then.

ghost avatar Jun 09 '23 12:06 ghost