merge suspend branch?

[TRPB]

Thanks for all your hard work on this. The suspend branch works great, but it is without audio, can you merge the two branches so we can have both suspend and audio?

[JPyke3]

Any updates on this one?

EDIT: Jokes it got merged im blind

[MoonPadUSer]

@JPyke3 I saw the merged branch, but I when I run make it spits out:

/home/fabian/Downloads/mbp2018-bridge-drv-suspend/vhci/vhci.c:49:20: error: ‘struct usb_bus’ has no member named ‘uses_dma’
   49 |     vhci->hcd->self.uses_dma = 1;
      |        

but there is no struct usb_bus anywhere in the code, did it work for you?

[JPyke3]

@MoonPadUSer Seems like suspend got merged in a bit ago, see the commit 1d4125010352133cb6b51262483f9ae85add9882. This is when i run make on master:

make -C /lib/modules/5.6.6-2-mbp/build M=/home/jacob/Development/mbp2018-bridge-drv modules
make[1]: Entering directory '/usr/lib/modules/5.6.6-2-mbp/build'
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/pci.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/mailbox.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/queue.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/queue_dma.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/vhci/vhci.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/vhci/queue.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/vhci/transfer.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/audio/audio.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/audio/protocol.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/audio/protocol_bce.o
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/audio/pcm.o
  LD [M]  /home/jacob/Development/mbp2018-bridge-drv/bce.o
  MODPOST 1 modules
  CC [M]  /home/jacob/Development/mbp2018-bridge-drv/bce.mod.o
  LD [M]  /home/jacob/Development/mbp2018-bridge-drv/bce.ko
make[1]: Leaving directory '/usr/lib/modules/5.6.6-2-mbp/build'

I'm guessing vhci is all the suspend stuff. This is where my knowledge starts to become limited, but at least on my MBP that im running arch on my suspend is working, although a bit slow

[MoonPadUSer]

@JPyke3 the problem is, it seems to suspend (but I'm not sure about that) but then there's no way to resume. It's basically a black screen, and I have to shut it down, and then turn it back on.

[MoonPadUSer]

@JPyke3 yeah, ok, now that you say it, my suspend is working too, but it is so slow, I thought it didn't work

[JPyke3]

@MoonPadUSer yeah it's reaaaallly slow. Not totally sure why as this goes way beyond my knowledge now. But at least it works :)