MBrouns

I think I'm okay with dropping 3.7 support. EOL in 8 months is soon enough and if it makes this feature easier to implement I'd say go for it

It seems that there is also a standard test in `scikit-learn`s check_estimator that verifies this feature_names_out behaviour: https://github.com/scikit-learn/scikit-learn/blob/36958fb24/sklearn/utils/estimator_checks.py#L3921 We should probably go over the test cases from `estimator_checks` to see...

You never know, but overall I think we managed to keep deprecations low. Might as well remove it as a dependency in the meantime

Changing the relevant parts to the following fixed it for me: ``` # # Escape JSON string # function json_escape() { echo -n "$1" | python3 -c 'import json,sys; print(json.dumps(sys.stdin.read()))'...

I took a brief look, but the only thing I could imagine failing is the `shape_delta` when its set to true. Is that indeed what's happening?

I'm not sure if changing `args` directly is a great way to solve this because we use it later in `result = func(*args, **kwargs)` Maybe something like this? ``` if...

Thanks for that lightning-quick response! Unfortunately we do enable other subcharts in the mainchart that have CRDs, so I don't think that'll fix it for us. The weird thing is...

version.BuildInfo{Version:"v3.13.3", GitCommit:"c8b948945e52abba22ff885446a1486cb5fd3474", GitTreeState:"clean", GoVersion:"go1.20.11"}

I agree that it's weird, but it does seem to be what's happening. Running `helm install test . --set 'subchart.enabled=false'` results in the CRD not being installed for the chart...

I looked into it a bit further and took the very blunt approach of calling `helmchartutil.ProcessDependenciesWithMerge` before `applyCRDs` is called and that does result in the crd of the subchart...