shapash icon indicating copy to clipboard operation
shapash copied to clipboard

Add support for Python 3.10

Open quassy opened this issue 3 years ago • 4 comments

Description of Problem: Currently only Python 3.6 to 3.9 seem to be officially supported.

Overview of the Solution: Drop support for 3.6 which is EOL, add support of 3.10. Check dependencies, run tests, adapt GitHub workflow to 3.10, etc.

quassy avatar Feb 02 '22 17:02 quassy

Thank you for the issue. Indeed, it would be great to remove 3.6 and add 3.10 We will see about adding this change to our future changes or you can also propose a pull request

ThomasBouche avatar Feb 03 '22 10:02 ThomasBouche

Hi,

I'm also interested in the support for Python 3.10. I saw that there is a draft Pull Request @ThomasBouche Is it ready to merge or there is some remaining work on it? Do you need any help?

Thanks

garaud avatar Aug 08 '22 13:08 garaud

Hi, To support Python 3.10, we have problems with dependency compatibility:

  • ACV (https://github.com/salimamoukou/acv00) does not support python 3.10, the maintainer was working on it before the summer.
  • At the moment, there are compatibility issues between the latest version of Numba, and Numpy (https://github.com/numba/numba/issues/8263) which should be resolved soon. I can't find versions of these libs that work well on all versions of Python, I hope the next version of numba will solve problems.

I will test again when Numba makes a new release.

ThomasBouche avatar Aug 12 '22 12:08 ThomasBouche

Thank you @ThomasBouche for your answer. It seems quite tricky the numba/numpy versions dependency.

garaud avatar Aug 12 '22 14:08 garaud

Hi, As you can see, this issue is close, you can now use Shapash with a Python 3.10 !

ThomasBouche avatar Sep 06 '22 14:09 ThomasBouche

@ThomasBouche Great!!

Thanks

garaud avatar Sep 07 '22 10:09 garaud