shapash icon indicating copy to clipboard operation
shapash copied to clipboard

Loosen requirements strictness

Open quassy opened this issue 3 years ago • 1 comments

Currently setup.py is very strict on some requirements (and quite loose on others). This will make installing shapash in combination with other packages difficult as it can lead to incompatible versions. I think all == should be safe to replace with ~= as point releases are generally compatible (and it might make sense to specify a minimum scikit-learn version):

        'plotly==4.12.0',
        'matplotlib>=3.3.0',
        'numpy>1.18.0',
        'pandas>1.0.2',
        'shap>=0.36.0',
        'dash==1.17.0',
        'dash-bootstrap-components==0.9.1',
        'dash-core-components==1.13.0',
        'dash-daq==0.5.0',
        'dash-html-components==1.1.1',
        'dash-renderer==1.8.3',
        'dash-table==4.11.0',
        'nbformat>4.2.0',
        'numba==0.53.1',
        'scikit-learn'

quassy avatar Feb 02 '22 17:02 quassy

Thank you for the issue. We agree that we need to specify a minimum version and have less strict requirements. We will work in the next weeks or months on code refactoring and dependencies management. We will take into account your proposals or you can also propose a pull request

ThomasBouche avatar Feb 03 '22 10:02 ThomasBouche