lyzr
lyzr copied to clipboard
bug fixed in website_qa module - error in resolving urls
Description
In the website_qa module, extracted href tags are concatenated with the input URL, throwing an error in resolving it
What: Removed the code for concatenation and added URL validator
Why: To avoid errors in resolving URLs
How: Added validator package to verify the URL pattern
What type of PR is this?
- [ ] :gift: New feature (non-breaking change which adds functionality)
- [x] :bug: Bug fix (non-breaking change which fixes an issue)
- [ ] :bomb: Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] :memo: Documentation update
- [ ] :art: Refactor or style update
- [ ] :fire: Performance improvements
- [ ] :white_check_mark: Test
- [ ] :robot: Build
- [ ] :repeat: CI, review, release, devops, chore, etc.
Added tests?
- [x] :ballot_box_with_check: Yes
- [ ] :negative_squared_cross_mark: No, and this is why:
- [ ] :question: No, because I need help.
How can this be tested?
Test A
- Description: No changes
- Test Configuration: No change in configuration
- Test Instructions: No change in instruction
- Libraries: No changes
- Expected Result: Display the answer for the input query
[optional] Are there any post-deployment tasks we need to perform?
Checklist:
- [ ] :sunglasses: My code follows the style guidelines of this project.
- [ ] :ballot_box_with_check: I have performed a self-review of my code.
- [ ] :bookmark_tabs: I have commented my code, particularly in hard-to-understand areas.
- [ ] :bookmark: I have made corresponding changes to the documentation.
- [ ] :warning: My changes generate no new warnings.
- [ ] :monocle_face: I have added tests that prove my fix is effective or that my feature works.
- [ ] :white_check_mark: New and existing unit tests pass locally with my changes.
- [ ] :link: Any dependent changes have been merged and published in downstream modules.
Required links:
- Linear Issue:
- Testing Notebook (Colab):
- Code Documentation (Confluence):
- User Documentation (Confluence):
Contributors:
- Shankesh Raju MS