Results 206 comments of Xia Li-yao

If the concern is to avoid creating a singleton only to append it immediately, there is `alter`.

> I think there is no hope for `insyboggle` -- even if we get rid of the closure I don't think ghc is sophisticated enough to deconstruct a Set and...

I am indeed suggesting the latter option, that we somehow fix `alter` to inline right, and then users of the library can implement similar functions such as `insertWith'` on top...

I think it should read in this order `"valid json, 34, satisfy"`, or the other way around, the reason being that the error comes from `value'` calling `word8` calling `satisfy`....

I was about to mention https://hackage.haskell.org/package/fingertree but if the goal is to implement "incremental quicksort" for `Seq` it does seem necessary to do this in containers and sufficient to keep...

You can add unit tests here: https://github.com/haskell/aeson/blob/master/tests/UnitTests.hs Many of those are in fact regression tests for previously found bugs. 1. Define your test as an `Assertion` 2. Add it to...

That's very cool! It's unfortunate that `gParseJSON` is exported in the toplevel modules `Data.Aeson`/`Data.Aeson.Types`. Users should really not depend on these Generics internals. It would be a good idea to...

Just wait for bergmark to look at the PR.

`genericToJSON`/`genericParseJSON` could also take a list of field encoders/decoders to customize the behavior on various fields (referred to by name or by type). I have [an example of this approach...

@torgeirsh That's a somewhat different issue, see also #690 and the extra [documentation added here](https://github.com/bos/aeson/pull/708/files). Don't hesitate to ask for further clarification though!