Lyrics
Created Enemies by Lauv
This is my first time contributing to this repo, I read the contribution instruction but wanted to make I was doing this correctly before proceeding.
Hey @02zchen thank you for the contribution! The text looks good, but the branch is unable to pass 2 automated tests, here's the long: https://travis-ci.com/Lyrics/lyrics/jobs/200190669
The first one is the absence of album directory, currently the file is located where only directories can be located. If this song has been released outside of album, please feel free to put it into a directory named after the song, that's what contributors have been doing so far in those cases. MusicBrainz tells me the album name is I Met You When I Was 18 (The Playlist) but I may be off, not too familiar with that artist's works.
The other failing test is the lack of metadata, it's needed to make the file contain description of what song it is in case it ever gets taken out of the database. Here's a basic example of metadata: https://github.com/Lyrics/lyrics/blob/master/database/A/Alice%20In%20Chains/Dirt/Would#L35
Okay, thanks. I will fix that and try again.
On Tue, May 14, 2019 at 8:05 PM Vincent Flyson [email protected] wrote:
Hey @02zchen https://github.com/02zchen thank you for the contribution! The text looks good, but the branch is unable to pass 2 automated tests, here's the long: https://travis-ci.com/Lyrics/lyrics/jobs/200190669
The first one is the absence of album directory, currently the file is located where only directories can be located. If this song has been released outside of album, please feel free to put it into a directory named after the song, that's what contributors have been doing so far in those cases. MusicBrainz tells me the album name is I Met You When I Was 18 (The Playlist) but I may be off, not too familiar with that artist's works.
The other failing test is the lack of metadata, it's needed to make the file contain description of what song it is in case it ever gets taken out of the database. Here's a basic example of metadata: https://github.com/Lyrics/lyrics/blob/master/database/A/Alice%20In%20Chains/Dirt/Would#L35
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Lyrics/lyrics/pull/324?email_source=notifications&email_token=AH6ZJLZXIZPG5LKUQTSDFZLPVNHS5A5CNFSM4HM55LSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVNEFZI#issuecomment-492454629, or mute the thread https://github.com/notifications/unsubscribe-auth/AH6ZJL47C5TU7JHOIPTI7DTPVNHS5ANCNFSM4HM55LSA .