flutterlocation icon indicating copy to clipboard operation
flutterlocation copied to clipboard

* fix #620 bug and #864 bug

Open wtwsky opened this issue 1 year ago • 2 comments

fix #620 bug and #864 bug

wtwsky avatar Aug 23 '23 06:08 wtwsky

To view this pull requests documentation preview, visit the following URL:

docs.page/lyokone/flutterlocation~889

Documentation is deployed and generated using docs.page.

docs-page[bot] avatar Aug 23 '23 06:08 docs-page[bot]

Did anyone test this and can confirm it indeed works?

bartekpacia avatar Nov 25 '23 22:11 bartekpacia

Any follow-up on this? @Lyokone @bartekpacia

alaincruz06 avatar May 05 '24 16:05 alaincruz06

I can merge this but I haven't tested this change myself. Did you check it?

bartekpacia avatar May 05 '24 16:05 bartekpacia

Was going to using the PR-ed branch from @wtwsky but it's "31 commits behind", think it'll be safer to fork it myself and copy the changes. In the meantime @wtwsky can you update your forked repo and try?

alaincruz06 avatar May 05 '24 16:05 alaincruz06

@alaincruz06 Please don't forget to update us on this matter. I cannot use this fork it has errors on pub get

ardeshir-33033 avatar May 06 '24 00:05 ardeshir-33033

@ardeshir-33033 @bartekpacia I have good news, I can confirm (after forking the library-from master branch-, running the changes on this PR in LocationPlugin.java, and testing the library) ,it works!!

I personally can't share my forked version of the repo because it is in a private repo, but it's easy to replicate, just:

  1. Fork master branch
  2. Execute the changes from this PR
  3. Then make a PR or merge.

alaincruz06 avatar May 06 '24 20:05 alaincruz06

Thanks, I'm merging this and releasing.

bartekpacia avatar May 06 '24 20:05 bartekpacia