flutterlocation icon indicating copy to clipboard operation
flutterlocation copied to clipboard

Update arguments of overridden method

Open TabooSun opened this issue 3 years ago • 2 comments

Fix #718

TabooSun avatar May 12 '22 01:05 TabooSun

@TabooSun Thank you for your pull request. I think your pr fixing the bug, so I'm trying to use your pr instead of package code. My pubspec.yaml:

location:
    git: https://github.com/TabooSun/flutterlocation.git

When I run flutter pub get there's error:

Could not find a file named "pubspec.yaml" in https://github.com/TabooSun/flutterlocation.git 49e699312c4db95eabcc8ad922f6df42fe37a5d2.
pub get failed (1; Could not find a file named "pubspec.yaml" in https://github.com/TabooSun/flutterlocation.git 49e699312c4db95eabcc8ad922f6df42fe37a5d2.)

How can I use your pr? Thank you.

vietstone-ng avatar May 12 '22 03:05 vietstone-ng

@vietstone-ng change your pubspec.yaml entry with this:

  location:
    git:
      url: https://github.com/TabooSun/flutterlocation.git
      path: packages/location
      ref: flutter-3-compatibility

zulfahmi93 avatar May 12 '22 04:05 zulfahmi93

The issue #718 that this PR was supposed to fix is already closed. That's why I'm closing this PR as well.

bartekpacia avatar Aug 09 '23 22:08 bartekpacia