StabilityMatrix icon indicating copy to clipboard operation
StabilityMatrix copied to clipboard

Possibly incorrect symlink creation for Data\Packages\ComfyUI\models\loras in 2.14.0-pre.1 + 2

Open richardm1 opened this issue 8 months ago • 2 comments

What happened?

Error when attempting to inference with a lora when Comfy is in symlink model sharing mode:

Image

The old/working strategy in dev.3 - note that loras in Data\Packages\ComfyUI\models is a symlink:

Image

The new (non-working) strategy in pre.1 and pre.2 - note loras is now an actual folder with two symlinks inside:

Image

Temporary workaround (i.e. restore the old strategy):

[first delete lora folder from SM\Data\Models]

...then... 

PS S:\SM\Data\Packages\ComfyUI\models> new-item -Target M:\SM\Data\Models\Lora -Path loras -Type SymbolicLink -Verbose
VERBOSE: Performing the operation "Create Symbolic Link" on target "Destination: S:\SM\Data\Packages\ComfyUI\models\loras".

    Directory: S:\SM\Data\Packages\ComfyUI\models

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
l----          2025-04-18    05:50                loras -> M:\SM\Data\Models\Lora

Inferencing with a lora now works. Restart of Comfy pkg will overwrite this workaround.

Steps to reproduce

No response

Relevant logs


Version

2.14.0-pre.1 and pre.2

What Operating System are you using?

Windows

richardm1 avatar Apr 18 '25 09:04 richardm1

Confirming similar breakage with the Linux appimage. It's setting up symlinks for invalid Lora and LyCORIS folders nested under loras. Rearranging my models folder tree to match what it's trying to accomplish doesn't work, either.

[INFO]  SharedFolders   Deleting existing junction at target /home/rm/StabilityMatrix/Data/Packages/ComfyUI/models/loras/Lora
[INFO]  SharedFolders   Updating junction link from /home/rm/StabilityMatrix/Data/Models/Lora to /home/rm/StabilityMatrix/Data/Packages/ComfyUI/models/loras/Lora
[INFO]  SharedFolders   Deleting existing junction at target /home/rm/StabilityMatrix/Data/Packages/ComfyUI/models/loras/LyCORIS
[INFO]  SharedFolders   Updating junction link from /home/rm/StabilityMatrix/Data/Models/LyCORIS to /home/rm/StabilityMatrix/Data/Packages/ComfyUI/models/loras/LyCORIS

richardm1 avatar Apr 24 '25 11:04 richardm1

Not sure if it is related, but I get some double nested folders as well, under Windows 11.

Image

magnusroe avatar Apr 28 '25 04:04 magnusroe

This issue is stale because it has been open 60 days with no activity. Remove the stale label or comment, else this will be closed in 7 days.

github-actions[bot] avatar Jun 28 '25 02:06 github-actions[bot]

Can't remove the "stale" label?

I'm not sure if I've implemented a workaround or if the bug is fixed!

richardm1 avatar Jul 03 '25 10:07 richardm1

This issue is stale because it has been open 60 days with no activity. Remove the stale label or comment, else this will be closed in 7 days.

github-actions[bot] avatar Sep 02 '25 02:09 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove the stale label or comment, else this will be closed in 7 days.

github-actions[bot] avatar Nov 06 '25 02:11 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Nov 13 '25 02:11 github-actions[bot]