Lychee
Lychee copied to clipboard
Refactor image processing to use pipeline instead of hard to read strategy
Feedback welcome.
To enable the code path, set PHOTO_PIPES=true
in .env
Codecov Report
Attention: Patch coverage is 93.55509%
with 31 lines
in your changes are missing coverage. Please review.
Project coverage is 86.69%. Comparing base (
41bea7a
) to head (911cbef
).
Additional details and impacted files
@kamil4 opinion ? @d7415 ? :)
@Kovah heads up. But I think this should make it easier for you to understand the add photo code flow.
Would have been nice to know this earlier. Spent a few hours trying to get into the structure, and can now spend more time changing everything. Not cool.
Would have been nice to know this earlier. Spent a few hours trying to get into the structure, and can now spend more time changing everything. Not cool.
Yeah sorry for that, I decided to make the code more readable a bit too late. :(
If you want I can rebase your PR on this one and apply the required changes so you can pick up from there?
@Kovah I went ahead and merged your PR in a new branch and added the required changes to integrate with the new pipe system. See the branch s3-pipes.
Fully stacked.