Lychee icon indicating copy to clipboard operation
Lychee copied to clipboard

Refactor image processing to use pipeline instead of hard to read strategy

Open ildyria opened this issue 5 months ago • 6 comments

Feedback welcome.

To enable the code path, set PHOTO_PIPES=true in .env

ildyria avatar Jan 27 '24 23:01 ildyria

Codecov Report

Attention: Patch coverage is 93.55509% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 86.69%. Comparing base (41bea7a) to head (911cbef).

Additional details and impacted files

codecov[bot] avatar Jan 27 '24 23:01 codecov[bot]

@kamil4 opinion ? @d7415 ? :)

ildyria avatar Jan 29 '24 09:01 ildyria

@Kovah heads up. But I think this should make it easier for you to understand the add photo code flow.

ildyria avatar Feb 03 '24 16:02 ildyria

Would have been nice to know this earlier. Spent a few hours trying to get into the structure, and can now spend more time changing everything. Not cool.

Kovah avatar Feb 03 '24 17:02 Kovah

Would have been nice to know this earlier. Spent a few hours trying to get into the structure, and can now spend more time changing everything. Not cool.

Yeah sorry for that, I decided to make the code more readable a bit too late. :(

If you want I can rebase your PR on this one and apply the required changes so you can pick up from there?

ildyria avatar Feb 03 '24 18:02 ildyria

@Kovah I went ahead and merged your PR in a new branch and added the required changes to integrate with the new pipe system. See the branch s3-pipes.

ildyria avatar Feb 04 '24 19:02 ildyria

Fully stacked.

ildyria avatar Apr 10 '24 17:04 ildyria