LycheeOrg
[Free to pick up] This new feature for adding copyright to albums #1838
Fixes #1838
Bringing the data of copyright to the frontend and adding a new route on api.php to edit the copyright value. for issue #1838. After getting this PR accepted i will work on the frontend side and push on frontend the rest
Thank you for your pull request. :)
Could you please add two tests:
- one where someone adds a copyright
- one where someone removes the copyright.
Also what should be the default value when it is not present?
You may also consider adding some localization strings: Like Copyright, Set copyright etc.. in the lang/xx/ folders.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.90%. Comparing base (
02e5a20) to head (9b332ff). Report is 51 commits behind head on master.
:exclamation: Current head 9b332ff differs from pull request most recent head 50b87bd. Consider uploading reports for the commit 50b87bd to get more accurate results
Additional details and impacted files
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ildyria Should i use google translate for the translations that i don't know or should i create the keys on all files and leave them empty?
@ildyria Should i use google translate for the translations that i don't know or should i create the keys on all files and leave them empty?
add the keys (the tests will require it anyway) and don't bother with google translate, just put the English. If someone wants to do the translation for their language, we will take the PR :) I will probably make a change on yours to support French (as it is my native language).
@ThanasisMpalatsoukas I fixed the conflicts with master.
We will merge this PR when:
- tests are added (see above)
- front-end supports it:
- You will need to make a PR on Lychee-front for that
- Once merged, we can rebuild the js files and we will be able to merge this one in master.
:smiley:
@ildyria Hey, was busy with work and stuff. Will probably take a look at it this week :)
Well yes. Those points have still not been resolved.
We will merge this PR when:
tests are added (see above)
front-end supports it:
- You will need to make a PR on Lychee-front for that
- Once merged, we can rebuild the js files and we will be able to merge this one in master.
Though what I would suggest is to fork this Pull request and start integrating against the Livewire branch of #1303 as it will make it significantly easier for the user to add tests and not have to care for the JS front side.
I'm interested on this. While finalising that interest, I would like to ping @ThanasisMpalatsoukas in case he's on this but forgot.
@ARMeeru thank you for being considerate and pinging me on this, sadly i have too personal work and am unable to continue with this at this point in time. You can go on and finalize this feature :)
@ARMeeru If you decide to go on this feature, I strongly advise you to have a look at https://github.com/LycheeOrg/Lychee/pull/2035 before.
You will probably want to check the following files: https://github.com/LycheeOrg/Lychee/blob/livewire/app/View/Components/Gallery/Album/Details.php https://github.com/LycheeOrg/Lychee/blob/livewire/resources/views/components/gallery/album/details.blade.php
https://github.com/LycheeOrg/Lychee/blob/livewire/app/Livewire/Components/Forms/Album/Properties.php https://github.com/LycheeOrg/Lychee/blob/livewire/resources/views/livewire/forms/album/properties.blade.php
And associated tests: https://github.com/LycheeOrg/Lychee/blob/livewire/tests/Livewire/Forms/Album/PropertiesTest.php
This should be a good read too: https://lycheeorg.github.io/docs/livewire.html