Merge Frontend Modes `gallery`, `view` and `frame` Into a Unified Frontend

Open nagmat84 opened this issue 3 years ago • 2 comments

The primary purpose of this PR is to sync https://github.com/LycheeOrg/Lychee-front/pull/323, but is also has some merits on its own.

This PR depends on https://github.com/LycheeOrg/Lychee/pull/1525. The changes of https://github.com/LycheeOrg/Lychee/pull/1525 are also incorporated in this PR (otherwise the CI would fail), but https://github.com/LycheeOrg/Lychee/pull/1525 should be merged first and independent of this PR.

This PR:

Cleans up some of the configuration options
Removes and simplifies everything which is not needed anymore on the backend, because the frontend takes care of those things on its own
It also removes the left-over of the "page" mode which has already been removed by https://github.com/LycheeOrg/Lychee/pull/1489, but failed to clean up completely.

Sep 19 '22 19:09 nagmat84

I am not sure yet about that way of dropping /frame, but I am curious of what it will look like.

Sep 20 '22 13:09 ildyria

Codecov Report

Merging #1522 (3417d3f) into master (231075e) will decrease coverage by 1.04%. The diff coverage is 60.00%.

Additional details and impacted files

Oct 21 '22 12:10 codecov[bot]

@kamil4 Need your checks. :) @nagmat84 resolved conflicts.

Nov 21 '22 22:11 ildyria